lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Jun 2022 12:14:21 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Jianglei Nie <niejianglei2021@....com> Cc: linux@...linux.org.uk, andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: sfp: fix memory leak in sfp_probe() On Thu, 23 Jun 2022 15:09:14 +0800 Jianglei Nie wrote: > sfp_probe() allocates a memory chunk from sfp with sfp_alloc(), when > devm_add_action() fails, sfp is not freed, which leads to a memory leak. > > We should free the sfp with sfp_cleanup() when devm_add_action() fails. .. and please add a Fixes tag
Powered by blists - more mailing lists