Message-ID: <YrQgMUaQeiwpUOcy@kroah.com>
Date:   Thu, 23 Jun 2022 10:11:29 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     mangosteen728 <mangosteen728@...il.com>
Cc:     ast <ast@...nel.org>, andrii <andrii@...nel.org>,
        bpf <bpf@...r.kernel.org>, daniel <daniel@...earbox.net>,
        BigBro Young <hi.youthinker@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] bpf/samples: fix tbpf_perf_event_output cpu's bug

On Thu, Jun 23, 2022 at 02:19:50AM +0800, mangosteen728 wrote:
> For the third parameter of this function,
> whose flags is set to 0, the perf_buffer__poll remains blocked.
> The flags value of BPF_F_CURRENT_CPU can receive the data normally.
> 
> Signed-off-by: mangosteen728 <mangosteen728@...il.com>
> ---
>  Hi Greg KH:
>  I am sorry for the wrong patch submitted due to my network reasons
>  and causing unnecessary trouble to the audit.
>  thanks
>  mangosteen728
> 
>  samples/bpf/trace_output_kern.c | 2 +-
>  1 files changed, 1 insertion(+), 1 deletions(-)
> 
> diff --git a/samples/bpf/trace_output_kern.c b/samples/bpf/trace_output_
> kern.c
> index b64815a..926844e 100644
> --- a/samples/bpf/trace_output_kern.c
> +++ b/samples/bpf/trace_output_kern.c
> @@ -22,7 +22,7 @@ int bpf_prog1(struct pt_regs *ctx)
>   data.pid = bpf_get_current_pid_tgid();
>   data.cookie = 0x12345678;
> 
> - bpf_perf_event_output(ctx, &my_map, 0, &data, sizeof(data));
> + bpf_perf_event_output(ctx, &my_map, BPF_F_CURRENT_CPU, &data,
> sizeof(data));
> 
>   return 0;
>  }
> -- 
> 1.8.3.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Powered by blists - more mailing lists