netdev - Re: [PATCH net] net: fix IFF_TX_SKB_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1656038444.6413577-1-xuanzhuo@linux.alibaba.com>
Date:   Fri, 24 Jun 2022 10:40:44 +0800
From:   Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        Alexander Lobakin <alobakin@...me>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] net: fix IFF_TX_SKB_NO_LINEAR definition

On Thu, 23 Jun 2022 16:32:32 +0300, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> The "1<<31" shift has a sign extension bug so IFF_TX_SKB_NO_LINEAR is
> 0xffffffff80000000 instead of 0x0000000080000000.
>
> Fixes: c2ff53d8049f ("net: Add priv_flags for allow tx skb without linear")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>

Thanks.

> ---
> Before IFF_CHANGE_PROTO_DOWN was added then this issue was not so bad.
>
>  include/linux/netdevice.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 89afa4f7747d..1a3cb93c3dcc 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1671,7 +1671,7 @@ enum netdev_priv_flags {
>  	IFF_FAILOVER_SLAVE		= 1<<28,
>  	IFF_L3MDEV_RX_HANDLER		= 1<<29,
>  	IFF_LIVE_RENAME_OK		= 1<<30,
> -	IFF_TX_SKB_NO_LINEAR		= 1<<31,
> +	IFF_TX_SKB_NO_LINEAR		= BIT_ULL(31),
>  	IFF_CHANGE_PROTO_DOWN		= BIT_ULL(32),
>  };
>
> --
> 2.35.1
>