netdev - Re: [PATCH] net/ipv4/ip_gre.c net/ipv6/ip6_gre.c: ip and gre header are recorded twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJGXZLg9Z3O8w_bTLhyU1m7Oemfx561X0ji0MdYRZG8XKmxBpg@mail.gmail.com>
Date:   Fri, 24 Jun 2022 16:51:41 +0300
From:   Aleksey Shumnik <ashumnik9@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        kuznet@....inr.ac.ru, xeb@...l.ru
Subject: Re: [PATCH] net/ipv4/ip_gre.c net/ipv6/ip6_gre.c: ip and gre header
 are recorded twice

On Fri, Jun 24, 2022 at 6:26 AM Jakub Kicinski <kuba@...nel.org> wrote:
> > > What socket type is the ping you have using?
> >
> > I use SOCK_DGRAM
>
> Strange.

Why is it strange?

> > I want to find out, the creation of gre and ip header twice, is it a
> > feature or a bug?
>
> I can't think why that'd be a feature. Could add this case to selftests
> to show how to repro and catch regressions?

I don't really know how to do it, but I'll try
If we just talk about selftests/net, then everything has passed

> > I did everything according to the instructions, hope everything is
> > correct this time.
>
> Nope, still mangled.

Strangely, everything works fine for me