netdev - Re: [net-next 2/2] dt-bindings: net: adin1110: Add docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrgvimyFdPVhL6hF@lunn.ch>
Date:   Sun, 26 Jun 2022 12:06:02 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     alexandru.tachici@...log.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, devicetree@...r.kernel.org,
        krzysztof.kozlowski+dt@...aro.org, gerhard@...leder-embedded.com,
        geert+renesas@...der.be, joel@....id.au, stefan.wahren@...e.com,
        wellslutw@...il.com, geert@...ux-m68k.org, robh+dt@...nel.org,
        d.michailidis@...gible.com, stephen@...workplumber.org,
        l.stelmach@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [net-next 2/2] dt-bindings: net: adin1110: Add docs

> +patternProperties:
> +  "^phy@[0-1]$":
> +    description: |
> +      ADIN1100 PHY that is present on the same chip as the MAC.
> +    type: object
> +
> +    properties:
> +      reg:
> +        items:
> +          maximum: 1
> +
> +    allOf:
> +      - if:
> +          properties:
> +            compatible:
> +              contains:
> +                const: adi,adin1110
> +        then:
> +          properties:
> +            compatible:
> +              const: ethernet-phy-id0283.bc91
> +        else:
> +          properties:
> +            compatible:
> +              const: ethernet-phy-id0283.bca1
> +
> +    required:
> +      - compatible
> +      - reg

Why is any of this needed? You register an MDIO bus and then use the
PHY at address 0 or 1. phylib should find the PHY and read its ID
register to load the driver. So i don't think there is anything useful
here.

	Andrew