netdev - Re: [PATCH 2/2] NFC: nxp-nci: Don't issue a zero length i2c_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Jun 2022 22:02:25 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Michael Walle <michael@...le.cc>
Cc:     Charles Gorand <charles.gorand@...innov.com>,
        Clément Perrochaud <clement.perrochaud@....com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] NFC: nxp-nci: Don't issue a zero length
 i2c_master_read()

On 26/06/2022 21:56, Michael Walle wrote:
> Am 2022-06-26 21:51, schrieb Krzysztof Kozlowski:
>> On 26/06/2022 21:42, Michael Walle wrote:
>>> There are packets which doesn't have a payload. In that case, the 
>>> second
>>> i2c_master_read() will have a zero length. But because the NFC
>>> controller doesn't have any data left, it will NACK the I2C read and
>>> -ENXIO will be returned. In case there is no payload, just skip the
>>> second i2c master read.
>>>
>>> Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI 
>>> driver")
>>> Signed-off-by: Michael Walle <michael@...le.cc>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Thanks, I'll reorder the patches in the next version otherwise
> there will likely be a conflict.

Yes.

> That should work with any patch
> tools (i.e. b4), shouldn't it?

You mean - re-ordering should work? Yes, no problem with that.

Best regards,
Krzysztof