netdev - Re: [PATCH] PCI: Add ACS quirk for Broadcom BCM5750x NICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLinvohm+jRupNZAV=G+OHg1buXvLDrs0yGgPY3o6NB8biA@mail.gmail.com>
Date:   Mon, 27 Jun 2022 00:30:03 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Netdev <netdev@...r.kernel.org>, linux-pci@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        Andrew Gospodarek <gospo@...adcom.com>,
        Pavan Chebbi <pavan.chebbi@...adcom.com>
Subject: Re: [PATCH] PCI: Add ACS quirk for Broadcom BCM5750x NICs

On Mon, Jun 13, 2022 at 5:16 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> On Thu, Jun 09, 2022 at 01:58:13PM -0500, Bjorn Helgaas wrote:
> > On Thu, Jun 09, 2022 at 01:41:47PM -0400, Michael Chan wrote:
> > > From: Pavan Chebbi <pavan.chebbi@...adcom.com>
> > >
> > > The Broadcom BCM5750x NICs may be multi-function devices.  They do
> > > not advertise ACS capability. Peer-to-peer transactions are not
> > > possible between the individual functions, so it is safe to treat
> > > them as fully isolated.
> > >
> > > Add an ACS quirk for these devices so the functions can be in
> > > independent IOMMU groups and attached individually to userspace
> > > applications using VFIO.
> > >
> > > Signed-off-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> > > Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> >
> > Applied to pci/virtualization for v5.20, thanks!
>
> I forgot to ask: is there a plan for future devices to include an ACS
> capability?  Or will we be stuck adding quirks forever?
>
I still have not heard back definitively from the hardware team yet.
It's likely that the next device will not have ACS but the one after
that will have it.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)