netdev - Re: [patch net-next 00/11] mlxsw: Implement dev info and dev flash for line cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yrltpz0wXW35xmgd@nanopsycho>
Date:   Mon, 27 Jun 2022 10:43:19 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org, petrm@...dia.com,
        pabeni@...hat.com, edumazet@...gle.com, mlxsw@...dia.com
Subject: Re: [patch net-next 00/11] mlxsw: Implement dev info and dev flash
 for line cards

Sat, Jun 18, 2022 at 08:12:20AM CEST, snelson@...sando.io wrote:
>
>
>On 6/15/22 10:40 AM, Jiri Pirko wrote:
>> Wed, Jun 15, 2022 at 11:13:35AM CEST, idosch@...dia.com wrote:
>> > On Tue, Jun 14, 2022 at 02:33:15PM +0200, Jiri Pirko wrote:
>> > > From: Jiri Pirko <jiri@...dia.com>
>> > > 
>> > > This patchset implements two features:
>> > > 1) "devlink dev info" is exposed for line card (patches 3-8)
>> > > 2) "devlink dev flash" is implemented for line card gearbox
>> > >     flashing (patch 9)
>> > > 
>> > > For every line card, "a nested" auxiliary device is created which
>> > > allows to bind the features mentioned above (patch 2).
>> > 
>[...]>>
>> > > 
>> > > The relationship between line card and its auxiliary dev devlink
>> > > is carried over extra line card netlink attribute (patches 1 and 3).
>> > > 
>> > > Examples:
>> > > 
>> > > $ devlink lc show pci/0000:01:00.0 lc 1
>> > > pci/0000:01:00.0:
>> > >    lc 1 state active type 16x100G nested_devlink auxiliary/mlxsw_core.lc.0
>> > 
>> > Can we try to use the index of the line card as the identifier of the
>> > auxiliary device?
>> 
>> Not really. We would have a collision if there are 2 mlxsw instances.
>> 
>
>Can you encode the base device's PCI info into the auxiliary device's id

Would look odd to he PCI BDF in auxdev addsess, wouldn't it?


>to make it unique?  Or maybe have each mlxsw instance have a unique ida value
>to encode in the linecard auxiliary device id?

Well, which value would that bring? It would be dynamic random number.
How the use would use that tho figure out the relation to the mlxsw
instance?

>
>sln