netdev - Re: [PATCH net v1 1/2] net: asix: fix "can't send until first packet is send" issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220628080008.GF13092@pengutronix.de>
Date:   Tue, 28 Jun 2022 10:00:08 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Lucas Stach <l.stach@...gutronix.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Anton Lundin <glance@....umu.se>,
        Lukas Wunner <lukas@...ner.de>, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, netdev@...r.kernel.org
Subject: Re: [PATCH net v1 1/2] net: asix: fix "can't send until first packet
 is send" issue

On Tue, Jun 28, 2022 at 09:50:42AM +0200, Lucas Stach wrote:
> Hi Oleksij,
> 
> subject of this patch looks strange. It should probably read "can't
> receive until first packet is sent".

rigth. But it is already taken.


> Regards,
> Lucas
> 
> Am Dienstag, dem 28.06.2022 um 06:49 +0200 schrieb Oleksij Rempel:
> > On Fri, Jun 24, 2022 at 09:51:38AM +0200, Oleksij Rempel wrote:
> > > If cable is attached after probe sequence, the usbnet framework would
> > > not automatically start processing RX packets except at least one
> > > packet was transmitted.
> > > 
> > > On systems with any kind of address auto configuration this issue was
> > > not detected, because some packets are send immediately after link state
> > > is changed to "running".
> > > 
> > > With this patch we will notify usbnet about link status change provided by the
> > > PHYlib.
> > > 
> > > Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
> > > Reported-by: Anton Lundin <glance@....umu.se>
> > > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > 
> > In different mail thread Anton reported as tested.
> > Tested-by: Anton Lundin <glance@....umu.se>
> > 
> > > ---
> > >  drivers/net/usb/asix_common.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
> > > index 632fa6c1d5e3..b4a1b7abcfc9 100644
> > > --- a/drivers/net/usb/asix_common.c
> > > +++ b/drivers/net/usb/asix_common.c
> > > @@ -431,6 +431,7 @@ void asix_adjust_link(struct net_device *netdev)
> > >  
> > >  	asix_write_medium_mode(dev, mode, 0);
> > >  	phy_print_status(phydev);
> > > +	usbnet_link_change(dev, phydev->link, 0);
> > >  }
> > >  
> > >  int asix_write_gpio(struct usbnet *dev, u16 value, int sleep, int in_pm)
> > > -- 
> > > 2.30.2
> > > 
> > > 
> > 
> 
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |