netdev - Re: [PATCH v9 11/12] dt-bindings: arm: freescale: scu-ocotp: Add i.MX8DXL compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220628143447.GA417671-robh@kernel.org>
Date:   Tue, 28 Jun 2022 08:34:47 -0600
From:   Rob Herring <robh@...nel.org>
To:     Abel Vesa <abel.vesa@....com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Joakim Zhang <qiangqing.zhang@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, linux-phy@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dong Aisheng <aisheng.dong@....com>
Subject: Re: [PATCH v9 11/12] dt-bindings: arm: freescale: scu-ocotp: Add
 i.MX8DXL compatible string

On Tue, Jun 07, 2022 at 02:16:24PM +0300, Abel Vesa wrote:
> Add i.MX8DXL compatible string to the scu-ocotp bindings.
> 
> Signed-off-by: Abel Vesa <abel.vesa@....com>
> ---
>  .../devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml        | 2 ++
>  1 file changed, 2 insertions(+)

Why are you adding this patch which adds a dependency on v9 of your 
series?

> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
> index 1c2d2486f366..73c9bd16ec35 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
> @@ -20,7 +20,9 @@ properties:
>            - enum:
>                - fsl,imx8qm-scu-ocotp
>                - fsl,imx8qxp-scu-ocotp
> +              - fsl,imx8dxl-scu-ocotp
>        - items:
> +          - const: fsl,imx8dxl-scu-ocotp
>            - const: fsl,imx8qxp-scu-ocotp

This doesn't make sense. Either you have a fallback or you don't.

>  
>    '#address-cells':
> -- 
> 2.34.3
> 
>