netdev - Re: [PATCH v3] ipv6/sit: fix ipip6_tunnel_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Jun 2022 09:05:05 -0600
From:   David Ahern <dsahern@...nel.org>
To:     zys.zljxml@...il.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org
Cc:     kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        eric.dumazet@...il.com, pabeni@...hat.com,
        katrinzhou <katrinzhou@...cent.com>
Subject: Re: [PATCH v3] ipv6/sit: fix ipip6_tunnel_get_prl return value

On 6/27/22 9:50 PM, zys.zljxml@...il.com wrote:
> From: katrinzhou <katrinzhou@...cent.com>
> 
> When kcalloc fails, ipip6_tunnel_get_prl() should return -ENOMEM.
> Move the position of label "out" to return correctly.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: 300aaeeaab5f ("[IPV6] SIT: Add SIOCGETPRL ioctl to get/dump PRL.")
> Signed-off-by: katrinzhou <katrinzhou@...cent.com>
> ---
> 
> Changes in v2:
> - Move the position of label "out"
> 
> Changes in v3:
> - Modify commit message
> 
>  net/ipv6/sit.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>