netdev - Re: [PATCH net-next v2 1/1] net: wwan: t7xx: Add AP CLDMA and GNSS port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <395cbc90-da43-c505-7bf0-18f8ac8e78cc@linux.intel.com>
Date:   Tue, 28 Jun 2022 14:26:55 -0700
From:   "moises.veleta" <moises.veleta@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        johannes@...solutions.net, ryazanov.s.a@...il.com,
        loic.poulain@...aro.org, m.chetan.kumar@...el.com,
        chandrashekar.devegowda@...el.com, linuxwwan@...el.com,
        chiranjeevi.rapolu@...ux.intel.com, haijun.liu@...iatek.com,
        ricardo.martinez@...ux.intel.com, dinesh.sharma@...el.com,
        ilpo.jarvinen@...ux.intel.com, moises.veleta@...el.com,
        Madhusmita Sahu <madhusmita.sahu@...el.com>
Subject: Re: [PATCH net-next v2 1/1] net: wwan: t7xx: Add AP CLDMA and GNSS
 port


On 6/28/22 13:46, Andy Shevchenko wrote:
> On Tue, Jun 28, 2022 at 09:50:24AM -0700, Moises Veleta wrote:
>> From: Haijun Liu <haijun.liu@...iatek.com>
>>
>> The t7xx device contains two Cross Layer DMA (CLDMA) interfaces to
>> communicate with AP and Modem processors respectively. So far only
>> MD-CLDMA was being used, this patch enables AP-CLDMA and the GNSS
>> port which requires such channel.
>>
>> GNSS AT control port allows Modem Manager to control GPS for:
>> - Start/Stop GNSS sessions,
>> - Configuration commands to support Assisted GNSS positioning
>> - Crash & reboot (notifications when resetting device (AP) & host)
>> - Settings to Enable/Disable GNSS solution
>> - Geofencing
>>
>> Rename small Application Processor (sAP) to AP.
>>
>> Signed-off-by: Haijun Liu <haijun.liu@...iatek.com>
>> Co-developed-by: Madhusmita Sahu <madhusmita.sahu@...el.com>
>> Signed-off-by: Madhusmita Sahu <madhusmita.sahu@...el.com>
>> Signed-off-by: Moises Veleta <moises.veleta@...ux.intel.com>
> Missed cutter '---' line here. Effectively invalidates your tag block and may
> not be applied (as no SoB present _as a tag_).
Thanks for catching that! Next time I will add '---' between the 
Signed-offs and the vX change log.
>> Change log in v2:
>> - Add to commit message renaming sAP to AP
>> - Add to commit message GNSS AT port info
>> - Lowercase X in constant prefix
>> - Add GNSS AT comment in static port file
>> ---
>>   drivers/net/wwan/t7xx/t7xx_hif_cldma.c     | 17 +++--
>>   drivers/net/wwan/t7xx/t7xx_hif_cldma.h     |  2 +-
>>   drivers/net/wwan/t7xx/t7xx_mhccif.h        |  1 +
>>   drivers/net/wwan/t7xx/t7xx_modem_ops.c     | 85 ++++++++++++++++++----
>>   drivers/net/wwan/t7xx/t7xx_modem_ops.h     |  3 +
>>   drivers/net/wwan/t7xx/t7xx_port.h          | 10 ++-
>>   drivers/net/wwan/t7xx/t7xx_port_ctrl_msg.c |  8 +-
>>   drivers/net/wwan/t7xx/t7xx_port_proxy.c    | 24 ++++++
>>   drivers/net/wwan/t7xx/t7xx_reg.h           |  2 +-
>>   drivers/net/wwan/t7xx/t7xx_state_monitor.c | 13 +++-
>>   drivers/net/wwan/t7xx/t7xx_state_monitor.h |  2 +


Regards,

Moises