netdev - Re: [PATCH 6/6] i2c: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87h743vigq.fsf@nvidia.com>
Date:   Wed, 29 Jun 2022 12:53:52 +0200
From:   Petr Machata <petrm@...dia.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
CC:     <netdev@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        Ido Schimmel <idosch@...dia.com>, Wolfram Sang <wsa@...nel.org>
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void


Uwe Kleine-König <u.kleine-koenig@...gutronix.de> writes:

>  drivers/net/ethernet/mellanox/mlxsw/i2c.c                 | 4 +---

> diff --git a/drivers/net/ethernet/mellanox/mlxsw/i2c.c b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> index ce843ea91464..50b7121a5e3c 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> @@ -656,14 +656,12 @@ static int mlxsw_i2c_probe(struct i2c_client *client,
>  	return err;
>  }
>  
> -static int mlxsw_i2c_remove(struct i2c_client *client)
> +static void mlxsw_i2c_remove(struct i2c_client *client)
>  {
>  	struct mlxsw_i2c *mlxsw_i2c = i2c_get_clientdata(client);
>  
>  	mlxsw_core_bus_device_unregister(mlxsw_i2c->core, false);
>  	mutex_destroy(&mlxsw_i2c->cmd.lock);
> -
> -	return 0;
>  }
>  
>  int mlxsw_i2c_driver_register(struct i2c_driver *i2c_driver)

For mlxsw:
Reviewed-by: Petr Machata <petrm@...dia.com>