netdev - RE: [Intel-wired-lan] [PATCH net-next] ice: Remove unnecessary NULL check before dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Jun 2022 12:44:31 +0000
From:   "G, GurucharanX" <gurucharanx.g@...el.com>
To:     Ziyang Xuan <william.xuanziyang@...wei.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next] ice: Remove unnecessary NULL
 check before dev_put



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Ziyang Xuan
> Sent: Thursday, June 16, 2022 10:23 AM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; intel-
> wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next] ice: Remove unnecessary NULL
> check before dev_put
> 
> Since commit b37a46683739 ("netdevice: add the case if dev is NULL"),
> dev_put(NULL) is safe, check NULL before dev_put() is not needed.
> 
> Signed-off-by: Ziyang Xuan <william.xuanziyang@...wei.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_lag.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Tested-by: Gurucharan <gurucharanx.g@...el.com> (A Contingent worker at Intel)