netdev - Re: [PATCH 6/6] i2c: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220629133504.syc6x4ptia3mnof5@pengutronix.de>
Date:   Wed, 29 Jun 2022 15:35:04 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Andrey Ryabinin <ryabinin.a.a@...il.com>
Cc:     Wolfram Sang <wsa@...nel.org>, dri-devel@...ts.freedesktop.org,
        linux-omap@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-mtd@...ts.infradead.org,
        linux-leds@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-crypto@...r.kernel.org,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        devicetree@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-clk@...r.kernel.org, alsa-devel@...a-project.org,
        linux-watchdog@...r.kernel.org,
        acpi4asus-user@...ts.sourceforge.net,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-usb@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-integrity@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-rtc@...r.kernel.org, netdev@...r.kernel.org,
        chrome-platform@...ts.linux.dev, linux-input@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org,
        openipmi-developer@...ts.sourceforge.net,
        linux-hwmon@...r.kernel.org, linux-fbdev@...r.kernel.org,
        patches@...nsource.cirrus.com, UNGLinuxDriver@...rochip.com,
        linux-pwm@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void

[Dropped most people from Cc, keeping only lists]

On Wed, Jun 29, 2022 at 04:11:26PM +0300, Andrey Ryabinin wrote:
> On 6/28/22 17:03, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <uwe@...ine-koenig.org>
> >
> > The value returned by an i2c driver's remove function is mostly ignored.
> > (Only an error message is printed if the value is non-zero that the
> > error is ignored.)
> >
> > So change the prototype of the remove function to return no value. This
> > way driver authors are not tempted to assume that passing an error to
> > the upper layer is a good idea. All drivers are adapted accordingly.
> > There is no intended change of behaviour, all callbacks were prepared to
> > return 0 before.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > ---
>                                     | 2 +-
> >  lib/Kconfig.kasan                                         | 1 +
> 
> > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan
> > index f0973da583e0..366e61639cb2 100644
> > --- a/lib/Kconfig.kasan
> > +++ b/lib/Kconfig.kasan
> > @@ -149,6 +149,7 @@ config KASAN_STACK
> >       depends on KASAN_GENERIC || KASAN_SW_TAGS
> >       depends on !ARCH_DISABLE_KASAN_INLINE
> >       default y if CC_IS_GCC
> > +     depends on !ARM
> >       help
> >         Disables stack instrumentation and thus KASAN's ability to detect
> >         out-of-bounds bugs in stack variables.
> 
> 
> What is this doing here?

Huh, that is wrong. I needed that for build testing, but it shouldn't
have been added to the patch. I'm dropping that for the final
submission.

Thanks for spotting.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)