lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Jun 2022 16:25:54 +0200 From: Maximilian Luz <luzmaximilian@...il.com> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Wolfram Sang <wsa@...nel.org> Cc: Uwe Kleine-König <uwe@...ine-koenig.org>, Miguel Ojeda <ojeda@...nel.org>, Jarkko Sakkinen <jarkko@...nel.org>, Stephen Boyd <sboyd@...nel.org>, "David S. Miller" <davem@...emloft.net>, Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <benjamin.tissoires@...hat.com>, Luka Perkov <luka.perkov@...tura.hr>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Bastien Nocera <hadess@...ess.net>, Hans de Goede <hdegoede@...hat.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Shawn Tu <shawnx.tu@...el.com>, Manivannan Sadhasivam <mani@...nel.org>, Pengutronix Kernel Team <kernel@...gutronix.de>, Kyungmin Park <kyungmin.park@...sung.com>, Andy Shevchenko <andy@...nel.org>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jakub Kicinski <kuba@...nel.org>, Rob Herring <robh+dt@...nel.org>, Mark Gross <markgross@...nel.org>, Pali Rohár <pali@...nel.org>, Mark Brown <broonie@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, openipmi-developer@...ts.sourceforge.net, linux-integrity@...r.kernel.org, linux-clk@...r.kernel.org, linux-crypto@...r.kernel.org, linux-gpio@...r.kernel.org, dri-devel@...ts.freedesktop.org, chrome-platform@...ts.linux.dev, linux-rpi-kernel@...ts.infradead.org, linux-input@...r.kernel.org, linux-hwmon@...r.kernel.org, linux-iio@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-leds@...r.kernel.org, linux-media@...r.kernel.org, patches@...nsource.cirrus.com, alsa-devel@...a-project.org, linux-omap@...r.kernel.org, linux-mtd@...ts.infradead.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, platform-driver-x86@...r.kernel.org, acpi4asus-user@...ts.sourceforge.net, linux-pm@...r.kernel.org, linux-pwm@...r.kernel.org, linux-rtc@...r.kernel.org, linux-staging@...ts.linux.dev, linux-serial@...r.kernel.org, linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org, linux-watchdog@...r.kernel.org, kasan-dev@...glegroups.com, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH 6/6] i2c: Make remove callback return void On 6/28/22 16:03, Uwe Kleine-König wrote: > From: Uwe Kleine-König <uwe@...ine-koenig.org> > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> [...] > drivers/platform/surface/surface3_power.c | 4 +--- [...] > diff --git a/drivers/platform/surface/surface3_power.c b/drivers/platform/surface/surface3_power.c > index 444ec81ba02d..3b20dddeb815 100644 > --- a/drivers/platform/surface/surface3_power.c > +++ b/drivers/platform/surface/surface3_power.c > @@ -554,7 +554,7 @@ static int mshw0011_probe(struct i2c_client *client) > return error; > } > > -static int mshw0011_remove(struct i2c_client *client) > +static void mshw0011_remove(struct i2c_client *client) > { > struct mshw0011_data *cdata = i2c_get_clientdata(client); > > @@ -564,8 +564,6 @@ static int mshw0011_remove(struct i2c_client *client) > kthread_stop(cdata->poll_task); > > i2c_unregister_device(cdata->bat0); > - > - return 0; > } > > static const struct acpi_device_id mshw0011_acpi_match[] = { For the quoted above: Reviewed-by: Maximilian Luz <luzmaximilian@...il.com>
Powered by blists - more mailing lists