netdev - Re: [PATCH net] net: tun: do not call napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220629091750.1f0dc8ed@kernel.org>
Date:   Wed, 29 Jun 2022 09:17:50 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        eric.dumazet@...il.com, syzbot <syzkaller@...glegroups.com>,
        Petar Penkov <ppenkov@...atrix.com>
Subject: Re: [PATCH net] net: tun: do not call napi_disable() twice

On Wed, 29 Jun 2022 09:37:52 +0000 Eric Dumazet wrote:
> syzbot reported a hang in tun_napi_disable() while RTNL is held.
> 
> Because tun.c logic is complicated, I chose to:
> 
> 1) rename tun->napi_enabled to tun->napi_configured
> 
> 2) Add a new boolean, tracking if tun->napi is enabled or not.

Not a huge surprise TBH :S

Is there a repro?