netdev - [PATCH net-next 1/4] net: lan966x: hardcode the number of external ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220630140237.692986-2-michael@walle.cc>
Date:   Thu, 30 Jun 2022 16:02:34 +0200
From:   Michael Walle <michael@...le.cc>
To:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Michael Walle <michael@...le.cc>
Subject: [PATCH net-next 1/4] net: lan966x: hardcode the number of external ports

Instead of counting the child nodes in the device tree, hardcode the
number of ports in the driver itself. The counting won't work at all
if an ethernet port is marked as disabled, eg. because it is not
connected on the board at all.

This is hardcoding the number of ports to eight for the generic
compatible string "microchip,lan966x-switch", although it clearly only
applies to the LAN9668. This is because, first, there is only one user
for now, and that is the LAN9668 and second, the generic compatible
string will be deprecated in favor of a more specific one. Therefore,
if there will be support for the LAN9662, it can be added by another
specific compatible string.

Signed-off-by: Michael Walle <michael@...le.cc>
---
 .../ethernet/microchip/lan966x/lan966x_main.c | 23 +++++++++++++------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
index 5784c4161e5e..d611b52d3a07 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
@@ -26,8 +26,16 @@
 
 #define IO_RANGES 2
 
+struct lan966x_info {
+	u8 num_phys_ports;
+};
+
+static const struct lan966x_info lan9668_info = {
+	.num_phys_ports = 8,
+};
+
 static const struct of_device_id lan966x_match[] = {
-	{ .compatible = "microchip,lan966x-switch" },
+	{ .compatible = "microchip,lan966x-switch", .data = &lan9668_info },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, lan966x_match);
@@ -992,9 +1000,10 @@ static int lan966x_reset_switch(struct lan966x *lan966x)
 static int lan966x_probe(struct platform_device *pdev)
 {
 	struct fwnode_handle *ports, *portnp;
+	const struct lan966x_info *info;
 	struct lan966x *lan966x;
 	u8 mac_addr[ETH_ALEN];
-	int err, i;
+	int err;
 
 	lan966x = devm_kzalloc(&pdev->dev, sizeof(*lan966x), GFP_KERNEL);
 	if (!lan966x)
@@ -1003,6 +1012,10 @@ static int lan966x_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, lan966x);
 	lan966x->dev = &pdev->dev;
 
+	info = device_get_match_data(&pdev->dev);
+	if (!info)
+		return -ENODEV;
+
 	if (!device_get_mac_address(&pdev->dev, mac_addr)) {
 		ether_addr_copy(lan966x->base_mac, mac_addr);
 	} else {
@@ -1025,11 +1038,7 @@ static int lan966x_probe(struct platform_device *pdev)
 	if (err)
 		return dev_err_probe(&pdev->dev, err, "Reset failed");
 
-	i = 0;
-	fwnode_for_each_available_child_node(ports, portnp)
-		++i;
-
-	lan966x->num_phys_ports = i;
+	lan966x->num_phys_ports = info->num_phys_ports;
 	lan966x->ports = devm_kcalloc(&pdev->dev, lan966x->num_phys_ports,
 				      sizeof(struct lan966x_port *),
 				      GFP_KERNEL);
-- 
2.30.2