netdev - Re: [PATCH bpf-next] selftests, bpf: remove AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ8uoz2KmpVf7nkJXUsHhmOtS2Td+rMOX8-PRqzz9QxJB-tZ3g@mail.gmail.com>
Date:   Thu, 30 Jun 2022 16:20:24 +0200
From:   Magnus Karlsson <magnus.karlsson@...il.com>
To:     Jesper Dangaard Brouer <jbrouer@...hat.com>
Cc:     "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Björn Töpel <bjorn@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        bpf <bpf@...r.kernel.org>, Xdp <xdp-newbies@...r.kernel.org>
Subject: Re: [PATCH bpf-next] selftests, bpf: remove AF_XDP samples

On Thu, Jun 30, 2022 at 3:44 PM Jesper Dangaard Brouer
<jbrouer@...hat.com> wrote:
>
>
> On 30/06/2022 11.37, Magnus Karlsson wrote:
> > From: Magnus Karlsson <magnus.karlsson@...el.com>
> >
> > Remove the AF_XDP samples from samples/bpf as they are dependent on
> > the AF_XDP support in libbpf. This support has now been removed in the
> > 1.0 release, so these samples cannot be compiled anymore. Please start
> > to use libxdp instead. It is backwards compatible with the AF_XDP
> > support that was offered in libbpf. New samples can be found in the
> > various xdp-project repositories connected to libxdp and by googling.
> >
> > Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
>
> Will you (or Maciej) be submitting these samples to XDP-tools[1] which
> is the current home for libxdp or maybe BPF-examples[2] ?
>
>   [1] https://github.com/xdp-project/xdp-tools
>   [2] https://github.com/xdp-project/bpf-examples
>
> I know Toke is ready to take over maintaining these, but we will
> appreciate someone to open a PR with this code...
>
> > ---
> >   MAINTAINERS                     |    2 -
> >   samples/bpf/Makefile            |    9 -
> >   samples/bpf/xdpsock.h           |   19 -
> >   samples/bpf/xdpsock_ctrl_proc.c |  190 ---
> >   samples/bpf/xdpsock_kern.c      |   24 -
> >   samples/bpf/xdpsock_user.c      | 2019 -------------------------------
> >   samples/bpf/xsk_fwd.c           | 1085 -----------------
>
> The code in samples/bpf/xsk_fwd.c is interesting, because it contains a
> buffer memory manager, something I've seen people struggle with getting
> right and performant (at the same time).

I can push xsk_fwd to BPF-examples. Though I do think that xdpsock has
become way too big to serve as a sample. It slowly turned into a catch
all demonstrating every single feature of AF_XDP. We need a minimal
example and then likely other samples for other features that should
be demoed. So I suggest that xdpsock dies here and we start over with
something minimal and use xsk_fwd for the forwarding and mempool
example.

Toke, I think you told me at Recipes in Paris that someone from RedHat
was working on an example. Did I remember correctly?

> You can get my ACK if someone commits to port this to [1] or [2], or a
> 3rd place that have someone what will maintain this in the future.
>
> --Jesper
>