netdev - Re: [PATCH] ibmvnic: Properly dispose of all skbs during a failover.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220630105218.7f23f31c@kernel.org>
Date:   Thu, 30 Jun 2022 10:52:18 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rick Lindsley <ricklind@...ibm.com>
Cc:     netdev@...r.kernel.org, bjking1@...ux.ibm.com, haren@...ux.ibm.com,
        nnac123@...ux.ibm.com, mmc@...ux.ibm.com
Subject: Re: [PATCH]     ibmvnic: Properly dispose of all skbs during a
 failover.

On Wed, 29 Jun 2022 17:03:17 -0700 Rick Lindsley wrote:
>     During a reset, there may have been transmits in flight that are no
>     longer valid and cannot be fulfilled.  Resetting and clearing the
>     queues is insufficient; each skb also needs to be explicitly freed
>     so that upper levels are not left waiting for confirmation of a
>     transmit that will never happen.  If this happens frequently enough,
>     the apparent backlog will cause TCP to begin "congestion control"
>     unnecessarily, culminating in permanently decreased throughput.
> 
>     This was noted during testing of heavy data transfers in
>     conjunction with multiple consecutive device failovers.

The indentation in the patch itself is unnecessary, git adds it when
formatting the output of git log (I'm guessing that's the reason you
went this way). Note that the same goes for the subject which looks
padded with spaces from the left.

Please add a Fixes tag pointing at a commit which introduced the
behavior (initial git commit if it's always been there), and repost 
with [PATCH net v2] in the subject.

Please keep the review tags you already received when reposting.