netdev - Re: [PATCH bpf-next] selftests, bpf: remove AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ8uoz0AVN2P+=stgHunu9vNMzr=BGv8P=Ohzqb3BqMDhoPWQg@mail.gmail.com>
Date:   Fri, 1 Jul 2022 15:16:39 +0200
From:   Magnus Karlsson <magnus.karlsson@...il.com>
To:     Srivats P <pstavirs@...il.com>
Cc:     Jesper Dangaard Brouer <jbrouer@...hat.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Björn Töpel <bjorn@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        bpf <bpf@...r.kernel.org>, Xdp <xdp-newbies@...r.kernel.org>
Subject: Re: [PATCH bpf-next] selftests, bpf: remove AF_XDP samples

On Fri, Jul 1, 2022 at 3:04 PM Srivats P <pstavirs@...il.com> wrote:
>
> > I can push xsk_fwd to BPF-examples. Though I do think that xdpsock has
> > become way too big to serve as a sample. It slowly turned into a catch
> > all demonstrating every single feature of AF_XDP. We need a minimal
> > example and then likely other samples for other features that should
> > be demoed. So I suggest that xdpsock dies here and we start over with
> > something minimal and use xsk_fwd for the forwarding and mempool
> > example.
>
> As an AF_XDP user, I want to say that I often refer to xdpsock to
> understand how to use a feature - it is very useful especially when
> there's a lack of good AF_XDP documentation.

Fully agree with you that we need a sample, but a better location for
it is in libxdp as xdpsock demonstrates how to use libxdp interfaces.
We cannot require that people install libxdp just to be able to
compile samples/bpf/. And the sample should be simpler IMO. So let us
use this as an opportunity to improve things.

> Srivats