netdev - Re: [PATCH iproute2-next v2] ip: Fix rx_otherhost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a9cc617-c903-d9e7-9120-649a3bab86c6@gmail.com>
Date:   Fri, 1 Jul 2022 08:42:18 -0600
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Itay Aveksis <itayav@...dia.com>
Subject: Re: [PATCH iproute2-next v2] ip: Fix rx_otherhost_dropped support

On 6/28/22 4:19 AM, Petr Machata wrote:
> The commit cited below added a new column to print_stats64(). However it
> then updated only one size_columns() call site, neglecting to update the
> remaining three. As a result, in those not-updated invocations,
> size_columns() now accesses a vararg argument that is not being passed,
> which is undefined behavior.
> 
> Fixes: cebf67a35d8a ("show rx_otherehost_dropped stat in ip link show")
> CC: Tariq Toukan <tariqt@...dia.com>
> CC: Itay Aveksis <itayav@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
> 
> Notes:
>     v2:
>     - Adjust to changes in the "32-bit quantity" patch
>     - Tweak the commit message for clarity
> 
>  ip/ipaddress.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

I merged main into next and now this one needs to be rebased.