netdev - Re: [PATCH] net: atlantic: fix potential memory leak in aq_ndev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220630201925.4138ab9c@kernel.org>
Date:   Thu, 30 Jun 2022 20:19:25 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jianglei Nie <niejianglei2021@....com>
Cc:     irusskikh@...vell.com, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: atlantic: fix potential memory leak in
 aq_ndev_close()

On Thu, 30 Jun 2022 01:56:45 +0800 Jianglei Nie wrote:
>  	err = aq_nic_stop(aq_nic);
> -	if (err < 0)
> -		goto err_exit;
>  	aq_nic_deinit(aq_nic, true);
>  
>  err_exit:

label is now unused, please make sure you build test your changes with
W=1