lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Jul 2022 21:34:35 +0200 From: Marek BehĂșn <kabel@...nel.org> To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk> Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, "Alvin __ipraga" <alsi@...g-olufsen.dk>, Claudiu Manoil <claudiu.manoil@....com>, "David S. Miller" <davem@...emloft.net>, DENG Qingfang <dqfext@...il.com>, Eric Dumazet <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>, George McCollister <george.mccollister@...il.com>, Hauke Mehrtens <hauke@...ke-m.de>, Jakub Kicinski <kuba@...nel.org>, Kurt Kanzenbach <kurt@...utronix.de>, Landen Chao <Landen.Chao@...iatek.com>, Linus Walleij <linus.walleij@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, Matthias Brugger <matthias.bgg@...il.com>, netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>, Sean Wang <sean.wang@...iatek.com>, UNGLinuxDriver@...rochip.com, Vivien Didelot <vivien.didelot@...il.com>, Vladimir Oltean <olteanv@...il.com>, Woojung Huh <woojung.huh@...rochip.com> Subject: Re: [PATCH RFC net-next 5/6] net: dsa: always use phylink for CPU and DSA ports On Wed, 29 Jun 2022 13:51:43 +0100 "Russell King (Oracle)" <rmk+kernel@...linux.org.uk> wrote: > Currently, we only use phylink for CPU and DSA ports if there is a > fixed-link specification, or a PHY specified. The reason for this > behaviour is that when neither is specified, there was no way for > phylink to know the link parameters. > > Now that we have phylink_set_max_link_speed() (which has become > possible through the addition of mac_capabilities) we now have the > ability to know the maximum link speed for a specific link, and can > now use phylink for this case as well. > > However, we need DSA drivers to report the interface mode being used > on these ports so that we can select a maximum speed appropriate for > the interface mode that hardware may have configured for the port. > > This is especially important with the conversion of DSA drivers to > phylink_pcs, as the PCS code only gets called if we are using > phylink for the port. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk> Reviewed-by: Marek BehĂșn <kabel@...nel.org> So this is the one that may break other drivers? Marek
Powered by blists - more mailing lists