[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <cover.1656707954.git.lukas@wunner.de>
Date: Fri, 1 Jul 2022 22:47:50 +0200
From: Lukas Wunner <lukas@...ner.de>
To: "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Eric Dumazet <edumazet@...gle.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org,
Steve Glendinning <steve.glendinning@...well.net>,
UNGLinuxDriver@...rochip.com, Oliver Neukum <oneukum@...e.com>,
Andre Edich <andre.edich@...rochip.com>,
Oleksij Rempel <o.rempel@...gutronix.de>,
Oleksij Rempel <linux@...pel-privat.de>,
Martyn Welch <martyn.welch@...labora.com>,
Gabriel Hojda <ghojda@...urs.ro>,
Christoph Fritz <chf.fritz@...glemail.com>,
Lino Sanfilippo <LinoSanfilippo@....de>,
Philipp Rosenberger <p.rosenberger@...bus.com>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Ferry Toth <fntoth@...il.com>, Andrew Lunn <andrew@...n.ch>,
Alan Stern <stern@...land.harvard.edu>
Subject: [PATCH net-next v2 0/3] Deadlock no more in LAN95xx
Second attempt at fixing a runtime resume deadlock in the LAN95xx USB driver:
In short, the driver isn't using the "nopm" register accessors in portions
of its runtime resume path, causing a deadlock. I'm fixing that by
auto-detecting whether nopm accessors shall be used, instead of
having to explicitly call them wherever it's necessary.
As a byproduct, code size shrinks significantly (see diffstat below).
Back in April I submitted a first attempt which was rejected by Alan Stern:
https://lore.kernel.org/all/6710d8c18ff54139cdc538763ba544187c5a0cee.1651041411.git.lukas@wunner.de/
That approach only detected whether a PM callback is running concurrently,
not whether the access is performed by the PM callback. I've come up with
a different approach which should resolve the objection (see patch [1/3]).
Thanks!
Lukas Wunner (3):
usbnet: smsc95xx: Fix deadlock on runtime resume
usbnet: smsc95xx: Clean up nopm handling
usbnet: smsc95xx: Clean up unnecessary BUG_ON() upon register access
drivers/net/usb/smsc95xx.c | 202 ++++++++++++++++---------------------
1 file changed, 86 insertions(+), 116 deletions(-)
--
2.36.1
Powered by blists - more mailing lists