netdev - Re: [PATCH net 1/2] i40e: Fix dropped jumbo frames statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220630210202.23165f16@kernel.org>
Date:   Thu, 30 Jun 2022 21:02:02 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
        Lukasz Cieplicki <lukaszx.cieplicki@...el.com>,
        netdev@...r.kernel.org, sassmann@...hat.com,
        Jedrzej Jagielski <jedrzej.jagielski@...el.com>,
        Gurucharan <gurucharanx.g@...el.com>
Subject: Re: [PATCH net 1/2] i40e: Fix dropped jumbo frames statistics

On Thu, 30 Jun 2022 14:49:39 -0700 Tony Nguyen wrote:
> From: Lukasz Cieplicki <lukaszx.cieplicki@...el.com>
> 
> Dropped packets caused by too large frames were not included in
> dropped RX packets statistics.
> Issue was caused by not reading the GL_RXERR1 register. That register
> stores count of packet which was have been dropped due to too large
> size.
> 
> Fix it by reading GL_RXERR1 register for each interface.
> 
> Repro steps:
> Send a packet larger than the set MTU to SUT
> Observe rx statists: ethtool -S <interface> | grep rx | grep -v ": 0"

You should count oversized frames to rx_length_errors.