netdev - Re: [PATCH net 1/3] docs: netdev: document that patch series length limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yr6mziKdr/rmuTjt@lunn.ch>
Date:   Fri, 1 Jul 2022 09:48:30 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, corbet@....net, linux-doc@...r.kernel.org
Subject: Re: [PATCH net 1/3] docs: netdev: document that patch series length
 limit

On Thu, Jun 30, 2022 at 10:46:05AM -0700, Jakub Kicinski wrote:
> We had been asking people to avoid massive patch series but it does
> not appear in the FAQ.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  Documentation/process/maintainer-netdev.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index c456b5225d66..862b6508fc22 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst
> @@ -136,6 +136,14 @@ it to the maintainer to figure out what is the most recent and current
>  version that should be applied. If there is any doubt, the maintainer
>  will reply and ask what should be done.
>  
> +How do I divide my work into patches?
> +-------------------------------------
> +
> +Put yourself in the shoes of the reviewer. Each patch is read separately
> +and therefore should constitute a comprehensible step towards your stated
> +goal. Avoid sending series longer than 15 patches, they clog review queue
> +and increase mailing list traffic when re-posted.
> +

Hi Jakub

I think a key concept is, big patch series takes longer to review, so
needs a bigger junk of time allocated to it, so often gets differed
until late. As a result, it will take longer to merge. A small series
can be reviewed in a short time, so Maintainers just do it, allowing
for quicker merging.

    Andrew