netdev - Re: [PATCH net] selftests/net: fix section name when using xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yr5RUQYQCB6sgoIo@Laptop-X1>
Date:   Fri, 1 Jul 2022 09:43:45 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Networking <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Andrii Nakryiko <andrii@...nel.org>
Subject: Re: [PATCH net] selftests/net: fix section name when using
 xdp_dummy.o

On Thu, Jun 30, 2022 at 12:08:11PM -0700, Andrii Nakryiko wrote:
> On Wed, Jun 29, 2022 at 11:22 PM Hangbin Liu <liuhangbin@...il.com> wrote:
> >
> > Since commit 8fffa0e3451a ("selftests/bpf: Normalize XDP section names in
> > selftests") the xdp_dummy.o's section name has changed to xdp. But some
> > tests are still using "section xdp_dummy", which make the tests failed.
> > Fix them by updating to the new section name.
> >
> > Fixes: 8fffa0e3451a ("selftests/bpf: Normalize XDP section names in selftests")
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> > ---
> 
> Thanks for fixing this! BTW, does iproute2 support selecting programs
> by its name (not section name)? Only the program name is unique, there
> could be multiple programs with the same SEC("xdp").

Good point. iproute2 do not support selecting programs by its name yet.
I will working on it to add this support.

Thanks
Hangbin