netdev - Re: [PATCH bpf-next] bpftool: Rename "bpftool feature list" into "... feature list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e765f097-f865-9253-f471-9d219a8b5f12@fb.com>
Date:   Fri, 1 Jul 2022 23:24:05 -0700
From:   Yonghong Song <yhs@...com>
To:     Quentin Monnet <quentin@...valent.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>
Cc:     Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpftool: Rename "bpftool feature list" into "...
 feature list_builtins"



On 7/1/22 2:38 AM, Quentin Monnet wrote:
> To make it more explicit that the features listed with "bpftool feature
> list" are known to bpftool, but not necessary available on the system
> (as opposed to the probed features), rename the "feature list" command
> into "feature list_builtins".
> 
> Note that "bpftool feature list" still works as before given that we
> recognise arguments from their prefixes; but the real name of the
> subcommand, in particular as displayed in the man page or the
> interactive help, will now include "_builtins".
> 
> Since we update the bash completion accordingly, let's also take this
> chance to redirect error output to /dev/null in the completion script,
> to avoid displaying unexpected error messages when users attempt to
> tab-complete.
> 
> Suggested-by: Daniel Borkmann <daniel@...earbox.net>
> Signed-off-by: Quentin Monnet <quentin@...valent.com>

Acked-by: Yonghong Song <yhs@...com>