netdev - RE: [PATCH 4/6] can: sja1000: Use of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB5922396ED77D1D2EF3D19DF486BC9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Sat, 2 Jul 2022 18:35:43 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
CC:     Wolfgang Grandegger <wg@...ndegger.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH 4/6] can: sja1000: Use of_device_get_match_data to get
 device data

Hi Marc,

Thanks for the feedback.


> Subject: Re: [PATCH 4/6] can: sja1000: Use of_device_get_match_data to
> get device data
> 
> On 02.07.2022 15:01:28, Biju Das wrote:
> > This patch replaces of_match_device->of_device_get_match_data
> > to get pointer to device data.
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > ---
> >  drivers/net/can/sja1000/sja1000_platform.c | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/can/sja1000/sja1000_platform.c
> b/drivers/net/can/sja1000/sja1000_platform.c
> > index f9ec7bd8dfac..24ea0f76e130 100644
> > --- a/drivers/net/can/sja1000/sja1000_platform.c
> > +++ b/drivers/net/can/sja1000/sja1000_platform.c
> > @@ -210,7 +210,6 @@ static int sp_probe(struct platform_device *pdev)
> >  	struct resource *res_mem, *res_irq = NULL;
> >  	struct sja1000_platform_data *pdata;
> >  	struct device_node *of = pdev->dev.of_node;
> > -	const struct of_device_id *of_id;
> >  	const struct sja1000_of_data *of_data = NULL;
> >  	size_t priv_sz = 0;
> >
> > @@ -243,11 +242,9 @@ static int sp_probe(struct platform_device *pdev)
> >  			return -ENODEV;
> >  	}
> >
> > -	of_id = of_match_device(sp_of_table, &pdev->dev);
> > -	if (of_id && of_id->data) {
> > -		of_data = of_id->data;
> > +	of_data = of_device_get_match_data(&pdev->dev);
> 
> Can you use device_get_match_data() instead?

Agreed, Will use device_get_match_data()

Cheers,
Biju