netdev - Re: [PATCH v9 bpf-next 9/9] bpf, x86_64: use bpf_jit_binary_pack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJmHTTri-s7dvFbLCXKZsZXopnVNFCpkmeHPYg2h6LkZg@mail.gmail.com>
Date:   Sat, 2 Jul 2022 20:03:56 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andres Freund <andres@...razel.de>
Cc:     Song Liu <song@...nel.org>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Kernel Team <kernel-team@...com>,
        Peter Zijlstra <peterz@...radead.org>, X86 ML <x86@...nel.org>,
        Ilya Leoshkevich <iii@...ux.ibm.com>,
        Song Liu <songliubraving@...com>
Subject: Re: [PATCH v9 bpf-next 9/9] bpf, x86_64: use bpf_jit_binary_pack_alloc

On Sat, Jul 2, 2022 at 8:02 PM Andres Freund <andres@...razel.de> wrote:
>
> Hi,
>
> On 2022-02-04 10:57:42 -0800, Song Liu wrote:
> > From: Song Liu <songliubraving@...com>
> >
> > Use bpf_jit_binary_pack_alloc in x86_64 jit. The jit engine first writes
> > the program to the rw buffer. When the jit is done, the program is copied
> > to the final location with bpf_jit_binary_pack_finalize.
> >
> > Note that we need to do bpf_tail_call_direct_fixup after finalize.
> > Therefore, the text_live = false logic in __bpf_arch_text_poke is no
> > longer needed.
>
> I think this broke bpf_jit_enable = 2.

Good. We need to remove that knob.
It's been wrong for a long time.