netdev - Re: Report: iproute2 build broken?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Jul 2022 12:59:45 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     Petr Machata <petrm@...dia.com>, David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: Report: iproute2 build broken?

Thanks Ido. That fixed it.
General question: do we need a "stable" iproute2?

cheers,
jamal

On Mon, Jul 4, 2022 at 12:34 PM Ido Schimmel <idosch@...sch.org> wrote:
>
> On Mon, Jul 04, 2022 at 11:51:39AM -0400, Jamal Hadi Salim wrote:
> > I have to admit i am being lazy here digging into the
> > root cause but normally iproute2 should just build
> > standalone regardless especially when it is a stable
> > version:
> >
> > $ cat include/version.h
> > static const char version[] = "5.18.0";
> >
> > $make
> > ..
> > ....
> > .....
> >   CC       iplink_bond.o
> > iplink_bond.c:935:10: error: initializer element is not constant
> >   .desc = ipstats_stat_desc_bond_tmpl_lacp,
> >           ^
> > iplink_bond.c:935:10: note: (near initialization for
> > ‘ipstats_stat_desc_xstats_bond_lacp.desc’)
> > iplink_bond.c:957:10: error: initializer element is not constant
> >   .desc = ipstats_stat_desc_bond_tmpl_lacp,
> >           ^
> > iplink_bond.c:957:10: note: (near initialization for
> > ‘ipstats_stat_desc_xstats_slave_bond_lacp.desc’)
> > ../config.mk:40: recipe for target 'iplink_bond.o' failed
> > make[1]: *** [iplink_bond.o] Error 1
> > Makefile:77: recipe for target 'all' failed
> > make: *** [all] Error 2
>
> Petr is OOO, not sure he will see your mail till later this week so I
> will try to help. Can you try with current main branch [1] or just take
> this patch [2] ?
>
> [1] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/log/
> [2] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=11e41a635cfab54e8e02fbff2a03715467e77ae9
>
> >
> > There's more if you fix that one given a whole lot
> > of dependencies
> >
> > cheers,
> > jamal