netdev - [PATCH ethtool 2/2] ethtool: remove restriction on ioctl commands having JSON output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220704054114.22582-3-matt@traverse.com.au>
Date:   Mon,  4 Jul 2022 05:41:14 +0000
From:   Mathew McBride <matt@...verse.com.au>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org, Mathew McBride <matt@...verse.com.au>
Subject: [PATCH ethtool 2/2] ethtool: remove restriction on ioctl commands having JSON output

The module-info/dump eeprom (-m/--module-info) is one such command
which is now able to produce JSON.

Signed-off-by: Mathew McBride <matt@...verse.com.au>
---
 ethtool.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ethtool.c b/ethtool.c
index 83bbde8..ece4ac0 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -6409,9 +6409,6 @@ int main(int argc, char **argp)
 	ctx.argp = argp;
 	netlink_run_handler(&ctx, args[k].nlchk, args[k].nlfunc, !args[k].func);
 
-	if (ctx.json) /* no IOCTL command supports JSON output */
-		exit_bad_args();
-
 	ret = ioctl_init(&ctx, args[k].no_dev);
 	if (ret)
 		return ret;
-- 
2.30.1