netdev - Re: [PATCH net-next 2/2] net: ip6mr: add RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Jul 2022 10:35:20 +0200
From:   David Lamparter <equinox@...c24.net>
To:     David Ahern <dsahern@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: ip6mr: add RTM_GETROUTE netlink op

On Sun, Jul 03, 2022 at 01:07:33PM -0600, David Ahern wrote:
> On 7/1/22 1:58 AM, David Lamparter wrote:
[...]
> > +	if (!netlink_strict_get_check(skb))
> > +		return nlmsg_parse_deprecated(nlh, sizeof(*rtm), tb, RTA_MAX,
> > +					      rtm_ipv6_policy, extack);
>
> Since this is new code, it always operates in strict mode.
>
[...]
> > +	err = nlmsg_parse_deprecated_strict(nlh, sizeof(*rtm), tb, RTA_MAX,
> > +					    rtm_ipv6_policy, extack);
>
> nlmsg_parse here.

Thanks for the feedback!  I've fixed the code, am currently retesting,
and will post a v2 shortly.


-David / equi