netdev - Re: [PATCH iproute2 v2] ip: Fix size_columns() invocation that passes a 32-bit quantity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 05 Jul 2022 16:20:12 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Petr Machata <petrm@...dia.com>
Cc:     netdev@...r.kernel.org, dsahern@...il.com,
        stephen@...workplumber.org
Subject: Re: [PATCH iproute2 v2] ip: Fix size_columns() invocation that passes a
 32-bit quantity

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@...workplumber.org>:

On Tue, 28 Jun 2022 12:17:31 +0200 you wrote:
> In print_stats64(), the last size_columns() invocation passes number of
> carrier changes as one of the arguments. The value is decoded as a 32-bit
> quantity, but size_columns() expects a 64-bit one. This is undefined
> behavior.
> 
> The reason valgrind does not cite this is that the previous size_columns()
> invocations prime the ABI area used for the value transfer. When these
> other invocations are commented away, valgrind does complain that
> "conditional jump or move depends on uninitialised value", as would be
> expected.
> 
> [...]

Here is the summary with links:
  - [iproute2,v2] ip: Fix size_columns() invocation that passes a 32-bit quantity
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=329fda186156

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html