netdev - Re: [PATCH net] Revert "tls: rx: move counting TlsDecryptErrors for sync"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220705144135.5685cf7f@kernel.org>
Date:   Tue, 5 Jul 2022 14:41:35 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Gal Pressman <gal@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        "Maxim Mikityanskiy" <maximmi@...dia.com>,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net] Revert "tls: rx: move counting TlsDecryptErrors for
 sync"

On Tue, 5 Jul 2022 14:08:37 +0300 Gal Pressman wrote:
> This reverts commit 284b4d93daee56dff3e10029ddf2e03227f50dbf.
> When using TLS device offload and coming from tls_device_reencrypt()
> flow, -EBADMSG error in tls_do_decryption() should not be counted
> towards the TLSTlsDecryptError counter.
> 
> Move the counter increase back to the decrypt_internal() call site in
> decrypt_skb_update().
> This also fixes an issue where:
> 	if (n_sgin < 1)
> 		return -EBADMSG;
> 
> Errors in decrypt_internal() were not counted after the cited patch.
> 
> Fixes: 284b4d93daee ("tls: rx: move counting TlsDecryptErrors for sync")
> Cc: Jakub Kicinski <kuba@...nel.org>
> Reviewed-by: Maxim Mikityanskiy <maximmi@...dia.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> Signed-off-by: Gal Pressman <gal@...dia.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>