netdev - Re: [net-next PATCH v2 0/5] PolarFire SoC macb reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69cdb133-c02a-e36b-b0a1-cf5ce81ad04f@microchip.com>
Date:   Tue, 5 Jul 2022 07:20:55 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <Conor.Dooley@...rochip.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <Nicolas.Ferre@...rochip.com>
CC:     <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [net-next PATCH v2 0/5] PolarFire SoC macb reset support

On 04.07.2022 14:45, Conor Dooley wrote:
> Hey all,
> Jakub requested that these patches be split off from the series
> adding the reset controller itself that I sent ~yesterday~ last
> week [0].
> 
> The Cadence MACBs on PolarFire SoC (MPFS) have reset capability and are
> compatible with the zynqmp's init function. I have removed the zynqmp
> specific comments from that function & renamed it to reflect what it
> does, since it is no longer zynqmp only.
> 
> MPFS's MACB had previously used the generic binding, so I also added
> the required specific binding.
> 
> For v2, I noticed some low hanging cleanup fruit so there are extra
> patches added for that:
> moving the init function out of the config structs, aligning the
> alignment of the zynqmp & default config structs with the other dozen
> or so structs & simplifing the error paths to use dev_err_probe().
> 
> Feel free to apply as many or as few of those as you like.

Other than minor comment on patch 3/5:

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> 
> Thanks,
> Conor.
> 
> Changes since v1:
> - added the 3 aforementioned cleanup patches
> - fixed two stylistic complaints from Claudiu
> 
> Conor Dooley (5):
>   dt-bindings: net: cdns,macb: document polarfire soc's macb
>   net: macb: add polarfire soc reset support
>   net: macb: unify macb_config alignment style
>   net: macb: simplify error paths in init_reset_optional()
>   net: macb: sort init_reset_optional() with other init()s
> 
>  .../devicetree/bindings/net/cdns,macb.yaml    |   1 +
>  drivers/net/ethernet/cadence/macb_main.c      | 106 +++++++++---------
>  2 files changed, 56 insertions(+), 51 deletions(-)
>