netdev - Re: [PATCH net-next v3] net: ip6mr: add RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YsVbSYGYtrAv+FY3@eidolon.nox.tf>
Date:   Wed, 6 Jul 2022 11:52:09 +0200
From:   David Lamparter <equinox@...c24.net>
To:     Jakub Kicinski <kuba@...nel.org>,
        Nikolay Aleksandrov <razor@...ckwall.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] net: ip6mr: add RTM_GETROUTE netlink op

On Mon, Jul 04, 2022 at 07:50:11PM -0700, Jakub Kicinski wrote:
> On Mon,  4 Jul 2022 12:52:23 +0200 David Lamparter wrote:
> > +const struct nla_policy rtm_ipv6_mr_policy[RTA_MAX + 1] = {
> > +	[RTA_SRC]		= NLA_POLICY_EXACT_LEN(sizeof(struct in6_addr)),
> > +	[RTA_DST]		= NLA_POLICY_EXACT_LEN(sizeof(struct in6_addr)),
> > +	[RTA_TABLE]		= { .type = NLA_U32 },
> > +};
> 
> net/ipv6/ip6mr.c:2515:25: warning: symbol 'rtm_ipv6_mr_policy' was not declared. Should it be static?

As the great poet of our time, Homer Simpson, would say:  "d'oh"

After thinking about it for a bit more, I agree with Nikolay that the
policy shouldn't be reused, so apart from adding the "static" here I'll
also rename it to clarify it's the RTM_GETROUTE policy.


-equi/David