netdev - Re: [RFC] ice: Reconfigure tx scheduling for SR-IOV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec6bfee4-cf0f-c5c1-a7b3-726d7e3c6d33@intel.com>
Date:   Wed, 6 Jul 2022 12:54:12 +0200
From:   "Wilczynski, Michal" <michal.wilczynski@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, Dima Chumak <dchumak@...dia.com>,
        "Maxim Mikityanskiy" <maximmi@...dia.com>,
        "Knitter, Konrad" <konrad.knitter@...el.com>
Subject: Re: [RFC] ice: Reconfigure tx scheduling for SR-IOV

Hi,

Thank you for your e-mail.

I considered using devlink-rate, and it seems like a good fit. However 
we would also

need support for rate-limiting for individual queues on the VF. 
Currently we have

two types of rate objects in devlink-rate: leaf and node. Would adding a 
third one - queue be accepted ?

Also we might want to add some other object rate parameters to currently 
existing ones, for

example 'priority'.


If this sounds acceptable I will work on the patch and submit it as 
soon, as it's ready.


Thanks,

Michał


On 7/6/2022 12:15 AM, Jakub Kicinski wrote:
> On Mon,  4 Jul 2022 13:45:13 +0200 Michal Wilczynski wrote:
>> If we were to follow normal flow, we would now use tc-filter family of
>> commands to direct types of interesting traffic to the correct nodes.
>> That is NOT the case in this implementation. In this POC, meaningful
>> classid number identifies scheduling node. Number of qdisc handle is a
>> queue number in a PF space. Reason for this - we want to support ALL
>> queues on the card including SR-IOV ones that are assigned to VF
>> netdevs.
> Have you looked at the devlink rate API? It should do what you need.
> Dima has been working on extending that API recently you may want to
> compare notes with him as well:
>
> https://lore.kernel.org/all/20220620152647.2498927-1-dchumak@nvidia.com/