netdev - Re: [PATCH] ftgmac100: Hold reference returned by of_get_child_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220706093459.2885de93@kernel.org>
Date:   Wed, 6 Jul 2022 09:34:59 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Liang He" <windhl@....com>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] ftgmac100: Hold reference returned by
 of_get_child_by_name()

On Wed, 6 Jul 2022 16:55:37 +0800 (CST) Liang He wrote:
> >Since we don't care about the value of the node we should add a helper
> >which checks for presence of the node and releases the reference,
> >rather than have to do that in this large function.
> >
> >Please also add a Fixes tag.  
> 
> Hi, Jakub,
> 
> Can you tell me where to add such helper?
> 
> you mean add a helper in of.h for common usasge or just add it in this file?

I was wondering about that. Since this is a fix let's keep it simple
and add the helper directly in the same source file.

If you have more time to spend on this try searching around the tree to
see if there are more places where such helper would help. If there are
we can move the helper to of.h and convert the users in -next.