netdev - Re: [PATCH net-next] net/sched: remove return value of unregister_tcf_proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220706125806.4362d1ad@kernel.org>
Date:   Wed, 6 Jul 2022 12:58:06 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     shaozhengchao <shaozhengchao@...wei.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "weiyongjun (A)" <weiyongjun1@...wei.com>,
        yuehaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] net/sched: remove return value of
 unregister_tcf_proto_ops

On Wed, 6 Jul 2022 01:52:38 +0000 shaozhengchao wrote:
> 	Thank you for your apply. This patch does just remove the
> return value and change the function type from int to void. It
> doesn't remove the function.

I understand. I'm asking you to replace the word "useless" with
"unused". Additionally I'm asking to consider if instead of returning
an error code the function should print a warning if error has occured.