netdev - Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220705182512.309f205e@kernel.org>
Date:   Tue, 5 Jul 2022 18:25:12 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Matthias May <matthias.may@...termo.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>
Subject: Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated
 IP frames

Please make sure to CC folks pointed out by scripts/get_maintainer.pl

On Tue, 5 Jul 2022 16:54:42 +0200 Matthias May wrote:
> Subject: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames

net-next may be more appropriate, since this never worked.
Unless it did, in which case we need a Fixes tag.

> The current code allows to inherit the TOS, TTL, DF from the payload
> when skb->protocol is ETH_P_IP or ETH_P_IPV6.
> However when the payload is VLAN encapsulated (e.g because the tunnel
> is of type GRETAP), then this inheriting does not work, because the
> visible skb->protocol is of type ETH_P_8021Q.
> 
> Add a check on ETH_P_8021Q and subsequently check the payload protocol.

Do we need to check for 8021AD as well?

> Signed-off-by: Matthias May <matthias.may@...termo.com>
> ---
>  net/ipv4/ip_tunnel.c | 21 +++++++++++++--------

Does ipv6 need the same treatment?