netdev - Re: [PATCH net-next v2 5/9] dt-bindings: net: Add Tegra234 MGBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a955644f-c3a3-d578-fb49-db19be148d01@linaro.org>
Date:   Wed, 6 Jul 2022 09:39:47 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bhadram Varka <vbhadram@...dia.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        thierry.reding@...il.com, jonathanh@...dia.com, kuba@...nel.org,
        catalin.marinas@....com, will@...nel.org, pabeni@...hat.com,
        davem@...emloft.net, edumazet@...gle.com
Subject: Re: [PATCH net-next v2 5/9] dt-bindings: net: Add Tegra234 MGBE

On 06/07/2022 05:12, Bhadram Varka wrote:
> Add device-tree binding documentation for the Tegra234 MGBE ethernet
> controller.
> 
> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
> Signed-off-by: Bhadram Varka <vbhadram@...dia.com>
> ---
>  .../bindings/net/nvidia,tegra234-mgbe.yaml    | 167 ++++++++++++++++++
>  1 file changed, 167 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml b/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml
> new file mode 100644
> index 000000000000..1a45cd374b19
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml
> @@ -0,0 +1,167 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/nvidia,tegra234-mgbe.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Tegra234 MGBE Device Tree Bindings

Either you agree with a comment/feedback or you answer and we keep
discussion going.

Ignoring a comment is a no-go.

Please fix everything what Rob pointed out.
> +
> +maintainers:
> +  - Thierry Reding <treding@...dia.com>
> +  - Jon Hunter <jonathanh@...dia.com>
> +
> +properties:
> +
> +  compatible:
> +    const: nvidia,tegra234-mgbe
> +
> +  reg:
> +    minItems: 3
> +    maxItems: 3
> +
> +  reg-names:
> +    items:
> +      - const: hypervisor
> +      - const: mac
> +      - const: xpcs
> +
> +  interrupts:
> +    minItems: 1
> +
> +  interrupt-names:
> +    items:
> +      - const: common

NAK.

Best regards,
Krzysztof