netdev - Re: [RESEND] [PATCH] p54: Use the bitmap API to allocate bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e1c7c7e-ef86-e4c9-92cc-f28bf6ec6b8a@gmail.com>
Date:   Thu, 7 Jul 2022 11:13:03 +0200
From:   Christian Lamparter <chunkeey@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Christian Lamparter <chunkeey@...glemail.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [RESEND] [PATCH] p54: Use the bitmap API to allocate bitmaps

Hi,

I'm sending this again because Android added HTML. Sorry for that.

On 04/07/2022 15:02, Christophe JAILLET wrote:
> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
> 
> It is less verbose and it improves the semantic.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Acked-by: Christian Lamparter <chunkeey@...il.com>

> ---
>   drivers/net/wireless/intersil/p54/fwio.c | 6 ++----
>   drivers/net/wireless/intersil/p54/main.c | 2 +-
>   2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
> index bece14e4ff0d..b52cce38115d 100644
> --- a/drivers/net/wireless/intersil/p54/fwio.c
> +++ b/drivers/net/wireless/intersil/p54/fwio.c
> @@ -173,10 +173,8 @@ int p54_parse_firmware(struct ieee80211_hw *dev, const struct firmware *fw)
>   		 * keeping a extra list for uploaded keys.
>   		 */
>   
> -		priv->used_rxkeys = kcalloc(BITS_TO_LONGS(priv->rx_keycache_size),
> -					    sizeof(long),
> -					    GFP_KERNEL);
> -
> +		priv->used_rxkeys = bitmap_zalloc(priv->rx_keycache_size,
> +						  GFP_KERNEL);
>   		if (!priv->used_rxkeys)
>   			return -ENOMEM;
>   	}
> diff --git a/drivers/net/wireless/intersil/p54/main.c b/drivers/net/wireless/intersil/p54/main.c
> index 115be1f3f33d..c1e1711382a7 100644
> --- a/drivers/net/wireless/intersil/p54/main.c
> +++ b/drivers/net/wireless/intersil/p54/main.c
> @@ -830,7 +830,7 @@ void p54_free_common(struct ieee80211_hw *dev)
>   	kfree(priv->output_limit);
>   	kfree(priv->curve_data);
>   	kfree(priv->rssi_db);
> -	kfree(priv->used_rxkeys);
> +	bitmap_free(priv->used_rxkeys);
>   	kfree(priv->survey);
>   	priv->iq_autocal = NULL;
>   	priv->output_limit = NULL;