netdev - Re: [PATCH net-next 2/2] eth: sp7021: switch to netif_napi_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 19:33:22 +0800
From:   呂芳騰 <wellslutw@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 2/2] eth: sp7021: switch to netif_napi_add_tx()

>
> The Tx NAPI should use netif_napi_add_tx().
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: wellslutw@...il.com
> ---
>  drivers/net/ethernet/sunplus/spl2sw_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c
> index 3773ce5e12cc..546206640492 100644
> --- a/drivers/net/ethernet/sunplus/spl2sw_driver.c
> +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c
> @@ -494,7 +494,7 @@ static int spl2sw_probe(struct platform_device *pdev)
>         /* Add and enable napi. */
>         netif_napi_add(ndev, &comm->rx_napi, spl2sw_rx_poll, NAPI_POLL_WEIGHT);
>         napi_enable(&comm->rx_napi);
> -       netif_napi_add(ndev, &comm->tx_napi, spl2sw_tx_poll, NAPI_POLL_WEIGHT);
> +       netif_napi_add_tx(ndev, &comm->tx_napi, spl2sw_tx_poll);
>         napi_enable(&comm->tx_napi);
>         return 0;
>
> --
> 2.36.1
>
Thanks for fixing the bug.

I applied the patch and did some tests.
I did not find any problem with patch.

Acked-by: Wells Lu <wellslutw@...il.com>