| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Jul 2022 00:54:25 +0800
From: kernel test robot <lkp@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: kbuild-all@...ts.01.org, netdev@...r.kernel.org,
edumazet@...gle.com, pabeni@...hat.com, borisp@...dia.com,
john.fastabend@...il.com, maximmi@...dia.com, tariqt@...dia.com,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 5/6] tls: create an internal header
Hi Jakub,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/tls-pad-strparser-internal-header-decrypt_ctx-etc/20220707-120420
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cd355d0bc60df51266d228c0f69570cdcfa1e6ba
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220708/202207080041.YiP2JbIW-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/4088937ef16f0f7a85bc39bb89ab75b33d5e8774
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jakub-Kicinski/tls-pad-strparser-internal-header-decrypt_ctx-etc/20220707-120420
git checkout 4088937ef16f0f7a85bc39bb89ab75b33d5e8774
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/fungible/funeth/funeth_tx.c: In function 'fun_tls_tx':
>> drivers/net/ethernet/fungible/funeth/funeth_tx.c:99:25: error: implicit declaration of function 'tls_offload_tx_resync_request'; did you mean 'tls_offload_rx_resync_request'? [-Werror=implicit-function-declaration]
99 | tls_offload_tx_resync_request(skb->sk, seq,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| tls_offload_rx_resync_request
cc1: some warnings being treated as errors
--
drivers/net/ethernet/netronome/nfp/nfp_net_common.c: In function 'nfp_net_tls_tx':
>> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:636:25: error: implicit declaration of function 'tls_offload_tx_resync_request'; did you mean 'tls_offload_rx_resync_request'? [-Werror=implicit-function-declaration]
636 | tls_offload_tx_resync_request(nskb->sk, seq,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| tls_offload_rx_resync_request
cc1: some warnings being treated as errors
vim +99 drivers/net/ethernet/fungible/funeth/funeth_tx.c
db37bc177dae89c Dimitris Michailidis 2022-02-24 78
db37bc177dae89c Dimitris Michailidis 2022-02-24 79 static struct sk_buff *fun_tls_tx(struct sk_buff *skb, struct funeth_txq *q,
db37bc177dae89c Dimitris Michailidis 2022-02-24 80 unsigned int *tls_len)
db37bc177dae89c Dimitris Michailidis 2022-02-24 81 {
b23f9239195a1af Dimitris Michailidis 2022-03-08 82 #if IS_ENABLED(CONFIG_TLS_DEVICE)
db37bc177dae89c Dimitris Michailidis 2022-02-24 83 const struct fun_ktls_tx_ctx *tls_ctx;
db37bc177dae89c Dimitris Michailidis 2022-02-24 84 u32 datalen, seq;
db37bc177dae89c Dimitris Michailidis 2022-02-24 85
504148fedb85429 Eric Dumazet 2022-06-30 86 datalen = skb->len - skb_tcp_all_headers(skb);
db37bc177dae89c Dimitris Michailidis 2022-02-24 87 if (!datalen)
db37bc177dae89c Dimitris Michailidis 2022-02-24 88 return skb;
db37bc177dae89c Dimitris Michailidis 2022-02-24 89
db37bc177dae89c Dimitris Michailidis 2022-02-24 90 if (likely(!tls_offload_tx_resync_pending(skb->sk))) {
db37bc177dae89c Dimitris Michailidis 2022-02-24 91 seq = ntohl(tcp_hdr(skb)->seq);
db37bc177dae89c Dimitris Michailidis 2022-02-24 92 tls_ctx = tls_driver_ctx(skb->sk, TLS_OFFLOAD_CTX_DIR_TX);
db37bc177dae89c Dimitris Michailidis 2022-02-24 93
db37bc177dae89c Dimitris Michailidis 2022-02-24 94 if (likely(tls_ctx->next_seq == seq)) {
db37bc177dae89c Dimitris Michailidis 2022-02-24 95 *tls_len = datalen;
db37bc177dae89c Dimitris Michailidis 2022-02-24 96 return skb;
db37bc177dae89c Dimitris Michailidis 2022-02-24 97 }
db37bc177dae89c Dimitris Michailidis 2022-02-24 98 if (seq - tls_ctx->next_seq < U32_MAX / 4) {
db37bc177dae89c Dimitris Michailidis 2022-02-24 @99 tls_offload_tx_resync_request(skb->sk, seq,
db37bc177dae89c Dimitris Michailidis 2022-02-24 100 tls_ctx->next_seq);
db37bc177dae89c Dimitris Michailidis 2022-02-24 101 }
db37bc177dae89c Dimitris Michailidis 2022-02-24 102 }
db37bc177dae89c Dimitris Michailidis 2022-02-24 103
db37bc177dae89c Dimitris Michailidis 2022-02-24 104 FUN_QSTAT_INC(q, tx_tls_fallback);
db37bc177dae89c Dimitris Michailidis 2022-02-24 105 skb = tls_encrypt_skb(skb);
db37bc177dae89c Dimitris Michailidis 2022-02-24 106 if (!skb)
db37bc177dae89c Dimitris Michailidis 2022-02-24 107 FUN_QSTAT_INC(q, tx_tls_drops);
db37bc177dae89c Dimitris Michailidis 2022-02-24 108
db37bc177dae89c Dimitris Michailidis 2022-02-24 109 return skb;
b23f9239195a1af Dimitris Michailidis 2022-03-08 110 #else
b23f9239195a1af Dimitris Michailidis 2022-03-08 111 return NULL;
db37bc177dae89c Dimitris Michailidis 2022-02-24 112 #endif
b23f9239195a1af Dimitris Michailidis 2022-03-08 113 }
db37bc177dae89c Dimitris Michailidis 2022-02-24 114
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists