netdev - Re: [PATCH] bpf: make sure mac_header was set before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 23:04:22 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Eric Dumazet <eric.dumazet@...il.com>,
        syzkaller <syzkaller@...glegroups.com>
Subject: Re: [PATCH] bpf: make sure mac_header was set before using it

On 7/7/22 8:40 PM, Alexei Starovoitov wrote:
> On Thu, Jul 7, 2022 at 11:36 AM Eric Dumazet <edumazet@...gle.com> wrote:
>> On Thu, Jul 7, 2022 at 8:31 PM Alexei Starovoitov
>> <alexei.starovoitov@...il.com> wrote:
>>> On Thu, Jul 7, 2022 at 11:20 AM <patchwork-bot+netdevbpf@...nel.org> wrote:
>>>>
>>>> Hello:
>>>>
>>>> This patch was applied to bpf/bpf.git (master)
>>>
>>> Are we sure it's bpf tree material?
>>> The fixes tag points to net-next tree.
>>
>> Fix is generic and should not harm bpf tree, or any tree if that matters.
> 
> Right. Just trying to understand the urgency/severity
> considering we're at rc5.

The Fixes tag points to the warning that has been added. I understand more
as a reference rather than the actual underlying bug that syzkaller was
able to trigger w/ classic bpf. So yeah, bpf tree seems reasonable, imho,
but also low risk from patch diff itself.

Thanks,
Daniel