netdev - Re: [net-next 10/15] net/tls: Perform immediate device ctx cleanup when possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220707065114.4tdx6f2lxig6lsof@sx1>
Date:   Wed, 6 Jul 2022 23:51:14 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Maxim Mikityanskiy <maximmi@...dia.com>
Subject: Re: [net-next 10/15] net/tls: Perform immediate device ctx cleanup
 when possible

On 06 Jul 19:21, Jakub Kicinski wrote:
>On Wed,  6 Jul 2022 16:24:16 -0700 Saeed Mahameed wrote:
>> From: Tariq Toukan <tariqt@...dia.com>
>>
>> TLS context destructor can be run in atomic context. Cleanup operations
>> for device-offloaded contexts could require access and interaction with
>> the device callbacks, which might sleep. Hence, the cleanup of such
>> contexts must be deferred and completed inside an async work.
>>
>> For all others, this is not necessary, as cleanup is atomic. Invoke
>> cleanup immediately for them, avoiding queueuing redundant gc work.
>>
>> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
>> Reviewed-by: Maxim Mikityanskiy <maximmi@...dia.com>
>> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
>
>Not sure if posting core patches as part of driver PRs is a good idea,
>if I ack this now the tag will not propagate.

I agree, how about the devlink lock removal  ? same thing ?