netdev - Re: [PATCH net-next 1/2] net: extract port range fields from fl_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 17:56:27 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Maksym Glubokiy <maksym.glubokiy@...ision.eu>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: extract port range fields from
 fl_flow_key

On Thu,  7 Jul 2022 11:35:38 +0300 Maksym Glubokiy wrote:
> +/**
> + * flow_dissector_key_ports_range:
> + *		tp:     port number from packet
> + *		tp_min: min port number in range
> + *		tp_max: max port number in range
> + */

This is not valid kdoc, please see
Documentation/doc-guide/kernel-doc.rst

> +struct flow_dissector_key_ports_range {
> +	union {
> +		struct flow_dissector_key_ports tp;
> +		struct {
> +			struct flow_dissector_key_ports tp_min;
> +			struct flow_dissector_key_ports tp_max;
> +		};
> +	};
> +};