netdev - Re: [PATCH bpf] selftests/bpf: Fix xdp_synproxy build failure if CONFIG_NF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZ4ep4gBpccuji4THxT92FqvjQBZ0iXhHtQx+ncYMkfYw@mail.gmail.com>
Date:   Fri, 8 Jul 2022 16:04:37 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Song Liu <song@...nel.org>
Cc:     Maxim Mikityanskiy <maximmi@...dia.com>,
        Shuah Khan <shuah@...nel.org>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Yauheni Kaliuta <ykaliuta@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>
Subject: Re: [PATCH bpf] selftests/bpf: Fix xdp_synproxy build failure if CONFIG_NF_CONNTRACK=m/n

On Fri, Jul 8, 2022 at 9:49 AM Song Liu <song@...nel.org> wrote:
>
> On Fri, Jul 8, 2022 at 6:03 AM Maxim Mikityanskiy <maximmi@...dia.com> wrote:
> >
> > When CONFIG_NF_CONNTRACK=m, struct bpf_ct_opts and enum member
> > BPF_F_CURRENT_NETNS are not exposed. This commit allows building the
> > xdp_synproxy selftest in such cases. Note that nf_conntrack must be
> > loaded before running the test if it's compiled as a module.
> >
> > This commit also allows this selftest to be successfully compiled when
> > CONFIG_NF_CONNTRACK is disabled.
> >
> > One unused local variable of type struct bpf_ct_opts is also removed.
> >
> > Reported-by: Yauheni Kaliuta <ykaliuta@...hat.com>
> > Signed-off-by: Maxim Mikityanskiy <maximmi@...dia.com>
> > Fixes: fb5cd0ce70d4 ("selftests/bpf: Add selftests for raw syncookie helpers")
>
> Given tools/testing/selftests/bpf/config specifies CONFIG_NF_CONNTRACK=y,
> I don't think this is really necessary.
>

We do redefine some of the kernel structs (e.g., bpf_iter.h), though,
to simplify build systems if it doesn't cost much maintenance burden.
Which seems to be the case here. So I've applied this to bpf-next
tree.


> Thanks,
> Song
>
>

[...]